[Biococoa-dev] More on BCSymbolSets

[Charles PARNOT]

At 7:38 PM -0500 3/4/05, Koen van der Drift wrote:
>Your code looks good, although you made:
>
>- (id)initWithSymbolArray:(NSArray *)anArray symbolSet:(BCSymbolSet *)aSet;
>
>not
>
>- (id)initWithString:(NSString *)aString symbolSet:(BCSymbolSet *)aSet;
>
>the designated initializer like you do now.
>
>Probably the array-version is a better idea, because that is already closer to the BCSequence than just a string. Otherwise you have an array, then make a string, and then make an array again, which is a waste of time (and yes, I am contradicting a previous message from me where I stated the opposite :)

In the current code, there are 2 independent initializers, which bothers me a lot. Like you say, the symbolArray one makes more sense for a designated initializer.

John wanted to make the class methods into instance methods, which is probably better, I agree. But I don't know if he had other concerns too. John?

charles

-- 
Help science go fast forward:
http://cmgm.stanford.edu/~cparnot/xgrid-stanford/

Charles Parnot
charles.parnot at stanford.edu

Room  B157 in Beckman Center
279, Campus Drive
Stanford University
Stanford, CA 94305 (USA)

Tel +1 650 725 7754
Fax +1 650 725 8021