[ghemical-devel] support for MPQC v2 was added
Tommi Hassinen
thassine@messi.uku.fi
Mon, 20 May 2002 16:11:07 +0300 (WET)
On Mon, 20 May 2002, Michael Banck wrote:
> > Finer granularity could be an investment in future. What about an
> > 3-digit or 4-digit version numbers like ABC or ABCC where
> >
> > A = major
> > B = minor
> > C = micro
> >
> > version number? I you guys give me the version information, I promise I'll
> > do the rest! :)
>
> If you're talking about MPQC_VERSION, it's probably as easy as doing
>
> AC_DEFINE_UNQUOTED(MPQC_MAJOR_VERSION, $SC_MAJOR_VERSION)
> AC_DEFINE_UNQUOTED(MPQC_MINOR_VERSION, $SC_MINOR_VERSION)
> AC_DEFINE_UNQUOTED(MPQC_MICRO_VERSION, $SC_MICRO_VERSION)
>
> to configure.in and the appropriate statements in config.h.in.
>
> MAJOR_VERSION is 1 or 2, and MINOR can be 0 or 1 if MAJOR is
> 2 at the moment.
>
> So we can do something similar to
>
> #if(MPQC_MAJOR_VERSION > 1 && MPQC_MINOR_VERSION > 0)
> using namespace sc;
> #ENDIF
Yep, this is in fact better than trying to use a single number. Also, it
could in fact be more correct to use the macro names
SC_MAJOR_VERSION
SC_MINOR_VERSION
SC_MICRO_VERSION
directly as you have used. Could you still send me an another patch with
all these changes?
Thanks,
Tommi